-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements ShutdownCode option and ShutdownSignal os.Signal wrapper #912
Closed
Commits on Oct 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for faa89e5 - Browse repository at this point
Copy the full SHA faa89e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 995e672 - Browse repository at this point
Copy the full SHA 995e672View commit details -
App.Done/App.Wait: Share internals
This is a proposed change to uber-go#912 by @jasonmills that DRYs up internal state management by unifying `chan os.Signal` and `chan ShutdownSignal` into a single interface as suggested in this comment: uber-go#912 (comment) This change isn't quite right because mapping os.Signal to a ShutdownSignal currently relies on a goroutine which isn't reliably shut down -- so we have leaking tests. Note that this also fixes a behavioral bug in uber-go#912: `Wait()` channels would not resolve if a plain signal was received.
Configuration menu - View commit details
-
Copy full SHA for c9972dd - Browse repository at this point
Copy the full SHA c9972ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 638daf4 - Browse repository at this point
Copy the full SHA 638daf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ebd130 - Browse repository at this point
Copy the full SHA 7ebd130View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4e5c2a - Browse repository at this point
Copy the full SHA b4e5c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 848742a - Browse repository at this point
Copy the full SHA 848742aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a69d369 - Browse repository at this point
Copy the full SHA a69d369View commit details
Commits on Oct 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 196f699 - Browse repository at this point
Copy the full SHA 196f699View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.