Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements ShutdownCode option and ShutdownSignal os.Signal wrapper #912

Closed
wants to merge 9 commits into from

Commits on Oct 27, 2022

  1. Configuration menu
    Copy the full SHA
    faa89e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    995e672 View commit details
    Browse the repository at this point in the history
  3. App.Done/App.Wait: Share internals

    This is a proposed change to uber-go#912 by @jasonmills
    that DRYs up internal state management by unifying
    `chan os.Signal` and `chan ShutdownSignal` into a single interface
    as suggested in this comment:
    uber-go#912 (comment)
    
    This change isn't quite right because mapping os.Signal to a
    ShutdownSignal currently relies on a goroutine
    which isn't reliably shut down -- so we have leaking tests.
    
    Note that this also fixes a behavioral bug in uber-go#912:
    `Wait()` channels would not resolve if a plain signal was received.
    abhinav authored and jasonmills committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c9972dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    638daf4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7ebd130 View commit details
    Browse the repository at this point in the history
  6. rebase from upstream

    jasonmills committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    b4e5c2a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    848742a View commit details
    Browse the repository at this point in the history
  8. update unsent error string

    jasonmills committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    a69d369 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Configuration menu
    Copy the full SHA
    196f699 View commit details
    Browse the repository at this point in the history