Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(Decorate): Explain that decorators can not add new values to the graph #1151

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Feb 6, 2024

I created #1144 because I was not sure whether a decorator
could add new values to the graph.

This clarifies the behavior.
We already have tests to verify this behavior.

Resolves #1144

…graph

I created uber-go#1144 because I was not sure whether a decorator
could add new values to the graph.

This clarifies the behavior.
We already have tests to verify this behavior.

Resolves uber-go#1144
Copy link
Contributor

@JacobOaks JacobOaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JacobOaks JacobOaks merged commit e7a70af into uber-go:master Feb 6, 2024
8 checks passed
@abhinav abhinav deleted the doc-decorator-no-provide branch February 7, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fx.Decorate does not add a missing object to the module
2 participants