Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log for span with exception in traced_function decorator doesn't match the opentracing spec #99

Open
condorcet opened this issue Jul 11, 2019 · 1 comment

Comments

@condorcet
Copy link
Contributor

Hello!

As I understand this logs are obsolete:
https://github.com/uber-common/opentracing-python-instrumentation/blob/master/opentracing_instrumentation/local_span.py#L166
https://github.com/uber-common/opentracing-python-instrumentation/blob/master/opentracing_instrumentation/local_span.py#L179

... and doesn't match the specification https://github.com/opentracing/specification/blob/master/semantic_conventions.md
There is no payload field and event="error' fits for exceptions better rather than "exception".

Am I right? Should we use standards fields in the decorator?

@yurishkuro
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants