We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello!
As I understand this logs are obsolete: https://github.com/uber-common/opentracing-python-instrumentation/blob/master/opentracing_instrumentation/local_span.py#L166 https://github.com/uber-common/opentracing-python-instrumentation/blob/master/opentracing_instrumentation/local_span.py#L179
... and doesn't match the specification https://github.com/opentracing/specification/blob/master/semantic_conventions.md There is no payload field and event="error' fits for exceptions better rather than "exception".
payload
event="error'
"exception"
Am I right? Should we use standards fields in the decorator?
The text was updated successfully, but these errors were encountered:
+1
Sorry, something went wrong.
No branches or pull requests
Hello!
As I understand this logs are obsolete:
https://github.com/uber-common/opentracing-python-instrumentation/blob/master/opentracing_instrumentation/local_span.py#L166
https://github.com/uber-common/opentracing-python-instrumentation/blob/master/opentracing_instrumentation/local_span.py#L179
... and doesn't match the specification https://github.com/opentracing/specification/blob/master/semantic_conventions.md
There is no
payload
field andevent="error'
fits for exceptions better rather than"exception"
.Am I right? Should we use standards fields in the decorator?
The text was updated successfully, but these errors were encountered: