Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to Tornado 6 #83

Open
nicholasamorim opened this issue May 22, 2019 · 4 comments
Open

Add support to Tornado 6 #83

nicholasamorim opened this issue May 22, 2019 · 4 comments

Comments

@nicholasamorim
Copy link
Contributor

Tornado 6 does not contain the StackContext used in the current implementation.

How could we support Tornado 6? Should one of the already-implemented ScopeManagers be used?

Should the contextvars module be used? That would limit the usage to Python 3.7+ though.
@condorcet
Copy link
Contributor

Because Tornado 6 fully asyncio-based framework, I think it's better to use AsyncioScopeManager. You can see this PoC about the problem opentracing/opentracing-python#118

@obi1kenobi obi1kenobi mentioned this issue Jun 24, 2020
Open
@Alessandro-Barbieri
Copy link

Any progress?

1 similar comment
@matej14086
Copy link

Any progress?

@yurishkuro
Copy link
Contributor

See #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nicholasamorim @condorcet @yurishkuro @Alessandro-Barbieri @matej14086