Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Add top level stats path validation #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

norberthu
Copy link

This change validates stats path and warns if any entries do not
start with carbon|servers|stats.

This change validates stats path and warns if any entries do not
start with carbon|servers|stats.
@JeremyGrosser
Copy link
Contributor

It'd be nice if you could configure these prefixes, rather than having them hardcoded. Not everybody follows the same schema for stats.

yashsarma referenced this pull request in lyft/statsrelay Feb 8, 2017
```
- CLOCK_REALTIME_COARSE -
clock_getres: 0 seconds | 4000000 nanoseconds
Cost (min): 12 cycles
Cost (avg): 53 cycles
Cost (max): 37061 cycles

- GETTIMEOFDAY -
gettimeofday_getres: 1us
Cost (min): 309 cycles
Cost (avg): 429 cycles
Cost (max): 107227 cycles
```
/cc @lyft/observability 
/cc @theatrus
theatrus referenced this pull request in lyft/statsrelay Feb 13, 2017
```
- CLOCK_REALTIME_COARSE -
clock_getres: 0 seconds | 4000000 nanoseconds
Cost (min): 12 cycles
Cost (avg): 53 cycles
Cost (max): 37061 cycles

- GETTIMEOFDAY -
gettimeofday_getres: 1us
Cost (min): 309 cycles
Cost (avg): 429 cycles
Cost (max): 107227 cycles
```
/cc @lyft/observability 
/cc @theatrus
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

theatrus referenced this pull request in lyft/statsrelay May 1, 2020
```
- CLOCK_REALTIME_COARSE -
clock_getres: 0 seconds | 4000000 nanoseconds
Cost (min): 12 cycles
Cost (avg): 53 cycles
Cost (max): 37061 cycles

- GETTIMEOFDAY -
gettimeofday_getres: 1us
Cost (min): 309 cycles
Cost (avg): 429 cycles
Cost (max): 107227 cycles
```
/cc @lyft/observability 
/cc @theatrus
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants