Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to apply anti-aliasing lowpass filter prior to Lanczos interpolation #60

Open
liamtoney opened this issue Jan 3, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@liamtoney
Copy link
Member

As a pre-processing step, we resample waveforms using the Lanczos method. We do this here:

st_i.interpolate(sampling_rate=decimation_rate, method='lanczos',
And here:
st_i.interpolate(sampling_rate=lowest_fs, method='lanczos', a=a_param)

Currently we are not applying an anti-aliasing filter first — this can lead to bad results! We need to add code to apply an appropriate lowpass filter prior to the interpolate() method being called.

@liamtoney liamtoney added the bug Something isn't working label Jan 3, 2022
@liamtoney
Copy link
Member Author

This is not as bad as I initially thought... interpolating occurs after filtering. So often (but not always) the user-defined bandpass will act as an AA filter. We still should fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants