Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one sensitivity used for multiple-sensor setups #9

Open
liamtoney opened this issue Aug 7, 2020 · 0 comments
Open

Only one sensitivity used for multiple-sensor setups #9

liamtoney opened this issue Aug 7, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@liamtoney
Copy link
Member

Currently, because of the one-to-one relationship set up by digitizer_sensor_pairs.json, a setup with more than one sensor attached to a single digitizer uses the same sensor sensitivity for all three sensors. For example, imagine a three-element array configuration where digitizer AEX is attached to SN49, SN50, and SN51. With the current code, the sensitivity for SN49 would be used for all three sensors.

A possible fix for this is to allow for lists (which are valid JSON) to be used in the pairs file. E.g., the top line in digitizer_sensor_pairs.json could be

"AEX" : ["SN49", "SN50", "SN51"]

and we could put some logic here in the script to select and apply the correct sensitivity to each element.

————————

However — is this even possible? Because we would need to know the correspondence between the .pri0, .pri1, and .pri2 files and the sensor. Is it possible to know this, e.g. from noting how the sensors are attached to the breakout box? If not, then there's no use in implementing the above, and users should instead use something like:

"AEX" : "any_made_up_id"

Which will result in a KeyError when looking up the sensitivity, and use DEFAULT_SENSITIVITY for all elements, which seems like the most logical behavior. Of course, this would need to be documented!

And speaking of documentation, non-UAF users who don't have their own sensor naming convention like us will want to do the above anyways — pinging @leighton-watson. 😃

————————

Pinging @davidfee5, @jegestrich, and @amiezzi as UAF DATA-CUBE3 users.

@liamtoney liamtoney added the bug Something isn't working label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant