Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for device brand and model. #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mspiegel
Copy link

This pull request adds support for ua-parser/uap-core@3021618.
It also cleans up the hashCode() methods for the various classes.

Michael Spiegel added 4 commits January 15, 2015 16:51
Use Matcher#appendReplacement() and Matcher#appendTail()
to perform a single pass through the device replacement
in order to avoid edge cases where the order of
replacement changes the generated string.
@mmarmol
Copy link

mmarmol commented May 12, 2015

Any update on this merge?

@BaiGang
Copy link

BaiGang commented Oct 18, 2015

+1 and LGTM.

I'm looking forward to this improvement.

@tmatei
Copy link

tmatei commented Nov 1, 2015

any updates on this?

@mmarmol
Copy link

mmarmol commented Mar 1, 2016

Hey @tmatei @BaiGang and @mspiegel I am currently working in a project that is bases on this lib but I am trying to put things up to date. For example I have a remote url load for the yaml and a scheduled load. I added this changes also, by the end of this week I will have also public maven repos so it can be easily included in projects. I would love to hear feedback from you.

https://github.com/mmarmol/uap-java

@hkkanuru
Copy link

why was this merge reverted? just curious, we would like to get brand and model?

@wangjy38
Copy link

Could this PR be reviewed again? device brand is useful in many circumstances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants