Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support brand and model in class Device. #10

Closed
BaiGang opened this issue Oct 17, 2015 · 1 comment
Closed

Support brand and model in class Device. #10

BaiGang opened this issue Oct 17, 2015 · 1 comment

Comments

@BaiGang
Copy link

BaiGang commented Oct 17, 2015

Currently class Device only includes family. We find that brand is usually more accurate in both the parsed results and in reflecting the characteristic of the agent. So it's necessary to add these two fields which are already supported in other uap libs.
@BaiGang
Copy link
Author

BaiGang commented Oct 18, 2015

Aha, it's been addressed in pull #4 . So I'm closing this.

@BaiGang BaiGang closed this as completed Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BaiGang