Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information icons contain dead links to AdGuard Knowledge Base #3401

Closed
9 tasks done
MarshalX opened this issue Oct 4, 2024 · 1 comment
Closed
9 tasks done

Information icons contain dead links to AdGuard Knowledge Base #3401

MarshalX opened this issue Oct 4, 2024 · 1 comment
Labels
fixed issue has been addressed

Comments

@MarshalX
Copy link

MarshalX commented Oct 4, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

They moved the knowledge base from the subdomain about a year ago (as I can tell from this commit AdguardTeam/AdguardFilters@f1398a1#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R40). Right now all old links do not work

I've created the pull request that fixes the issue, but unfortunately, I can not create them in the main repository because I am a new contributor. Here is the PR to my fork: MarshalX/uBlock#1

A specific URL where the issue occurs.

dashboard.html#3p-filters.html

Steps to Reproduce

  1. Open uBlock settings
  2. Navigate to "Filter lists"
  3. Click the information icon next to some AdGuard filters
image

Expected behavior

Links open documentation (https://adguard.com/kb/general/ad-filtering/adguard-filters/)

Actual behavior

Links return NGINX 404 (https://kb.adguard.com/en/general/adguard-ad-filters)

uBO version

N/A

Browser name and version

N/A

Operating System and version

N/A

@gorhill
Copy link
Member

gorhill commented Oct 4, 2024

I pulled your commit into the repo, thanks.

@MasterKia MasterKia added the fixed issue has been addressed label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issue has been addressed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants