Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling out bridge shouldnt regenerate config #39

Open
danjenkins opened this issue Aug 19, 2020 · 1 comment
Open

Rolling out bridge shouldnt regenerate config #39

danjenkins opened this issue Aug 19, 2020 · 1 comment

Comments

@danjenkins
Copy link

Right now, I think if you apply changes that only affect a bridge, OR need to restart a bridge using kubectl rollout restart deployment matrix-bridge-twitter for example.... it'll generate new config I think.... and the shared secrets wont be the same in the live version of synapse.

I think!

If the config exists, you shouldnt just go remake it? But then how do you deal with the issue of wanting to update the other config?

@Jaykul
Copy link

Jaykul commented Feb 14, 2021

Yeah, I've been having this same problem. I've been gradually tweaking the configuration of the bridge, but even if I make changes in values.yaml and upgrade the whole chart, if the bridges start after synapse, I have to restart synapse in order to restore communication.

I've been trying to think of a way to avoid regenerating the registration.yaml because helm re-runs helpers.tpl every time and makes new secrets. Would it be enough to just not copy in the initcontainer, it if it already exists, or would we have to copy it in the opposite direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants