Update Java versions #151
Merged
Update Java versions #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rossabaker
commented
Jun 19, 2024
rossabaker
commented
- Drops Java 8 on MacOS, which no longer exists. Fixes All PRs are failing on missing Temurin 8? #148.
- Bumps LTS version to 21. There's nothing special about 17 anymore.
rossabaker
commented
Jun 19, 2024
| ThisBuild / githubWorkflowJavaVersions := Seq(PrimaryJava, LTSJava) | ||
|
|
||
| // MacOS runners do not have temurin@8 | ||
| ThisBuild / githubWorkflowBuildMatrixExclusions := Seq( | ||
| MatrixExclude(Map("os" -> MacOS, "java" -> JavaSpec.temurin("8").render)) |
There was a problem hiding this comment.
This could use the PrimaryJava constant, but we really only need to drop what MacOS has dropped. Whenever PrimaryJava progresses to 11, this can be removed... unless MacOS has already dropped that, too.
There was a problem hiding this comment.
Would it be reasonable to bump PrimaryJava to 11 now? I don't have a lot of context but this is for new projects, and 8 seemed to be accelerating on it's way out
There was a problem hiding this comment.
I think we could bump to 11, but that can also happen in a follow up
There was a problem hiding this comment.
I asked Andrew about this and he proposed doing this bump in a follow-up just so it's more explicit haha thanks Andrew!
samspills
approved these changes
Jun 20, 2024
valencik
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.