Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generators can't validate query with updated TypeQL version #54

Open
dmitrii-ubskii opened this issue May 10, 2022 · 0 comments
Open

Generators can't validate query with updated TypeQL version #54

dmitrii-ubskii opened this issue May 10, 2022 · 0 comments

Comments

@dmitrii-ubskii
Copy link
Member

dmitrii-ubskii commented May 10, 2022 •
edited by flyingsilverfin
Loading

It appears that as the TypeDB Java client is updated, and the TypeQL version has changed, the string representation of a query changed. There are places where the generators look for a substring in the query (e.g. RelationGenerator.java:104) that can no longer appear. The loader ends up just ignoring the data with a generated query like

insert
$null isa null,
    has null "null";
@flyingsilverfin flyingsilverfin changed the title Generators can't validate query with latest TypeDB Java client Generators can't validate query with updated TypeQL May 10, 2022
@flyingsilverfin flyingsilverfin mentioned this issue May 10, 2022
Merged
flyingsilverfin added a commit that referenced this issue May 10, 2022
@flyingsilverfin
Reduce logical dependencies on TypeQL toString() (#56)
539fbfd 
## What is the goal of this PR?

As outlined in #54, a change in TypeQL meant that some of the `toString()` representations have changed. This PR reduces reliance on `toString()` for correctness, though more work needs to be done to eliminate the dependency.

## What are the changes implemented in this PR?

* Fix one `toString()` check that included a comma that no longer exists
* Replace to usages of `toString()` contains checks with operations over the TypeQL query object.
@flyingsilverfin flyingsilverfin changed the title Generators can't validate query with updated TypeQL Generators can't validate query with updated TypeQL version May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitrii-ubskii