Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pause scanning (i.e. when presenting) #131

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

qalandarov
Copy link
Contributor

If a user is taking an action with the result of the scanned barcode and in the meantime the app recognizes another barcode then the user's progress could be lost, hence the need for the ability to pause.

Also minor improvements:

  • final class
  • guard let captureSession = captureSession else -> guard let captureSession else

@qalandarov
Copy link
Contributor Author

@nathanfallet last one in today's batch :)

@twostraws
Copy link
Owner

Hello! While all contributions are generally welcome, I just want to confirm these features are coming about because you're hitting real-world problems with the library as-is, rather than just adding new features because new features are nice? Please remember that every new piece of code that goes in is code that needs to be maintained in the long term 🙂

@qalandarov
Copy link
Contributor Author

Hello! While all contributions are generally welcome, I just want to confirm these features are coming about because you're hitting real-world problems with the library as-is, rather than just adding new features because new features are nice? Please remember that every new piece of code that goes in is code that needs to be maintained in the long term 🙂

Hi Paul.
Yes, today's PRs were all because of real-life issues that were faced in a barcode-scanning app.
The issue that's faced for this particular PR:

  1. A barcode is scanned
  2. A bottom sheet is presented
  3. User wants to send a feedback about the product
  4. Email-composer sheet is presented
  5. When the camera detects another barcode the progress of the previous actions are lost

@nathanfallet
Copy link
Collaborator

Yes I understand the goal of those contributions, and I take time to review them.
Also, I totally changed my life a week ago, and in those changes I decided to dedicate my Fridays to open source (that's why I spend yesterday reviewing and resolving PRs across 3 major projects). So I'll keep maintaining that with time, reply to issues, etc...

@nathanfallet nathanfallet merged commit 303bd5a into twostraws:main Feb 24, 2024
1 check passed
@nathanfallet
Copy link
Collaborator

@qalandarov If you could also update documentation with all the options you added, that would be great 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants