Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pass-through assertion methods that are just forwarding parameters #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leifwalsh
Copy link
Contributor

@leifwalsh leifwalsh commented Jul 7, 2018

This deals with the "deprecated assertion names" like assertEquals forwarding to assertEqual, and possibly
others like them.

Closes #85

@leifwalsh leifwalsh added the bug Something isn't working label Jul 7, 2018
@leifwalsh leifwalsh self-assigned this Jul 7, 2018
@leifwalsh leifwalsh force-pushed the bug/deprecated-assertion-methods branch 2 times, most recently from 229aa52 to 0784a81 Compare July 7, 2018 00:43
…ters

This deals with the "deprecated assertion names" like assertEquals forwarding to assertEqual, and possibly
others like them.

Closes #85
Copy link
Contributor

@thejunglejane thejunglejane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In conjunction with #78, I think we have enough evidence now that we should rethink how we capture the note and the msg arguments. Let’s think through a different approach that handles both (and other permutations of the msg argument we can find/think of), and I can add tests for #78 like you did here for #85 to help get us started.

@thejunglejane thejunglejane changed the title Handle pass-through assertion methods that are just forwarding parame… Handle pass-through assertion methods that are just forwarding parameters Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants