Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include action result messages in Pull Request conversation thread. #223

Open
IstoraMandiri opened this issue Oct 4, 2022 · 2 comments · May be fixed by #224
Open

Include action result messages in Pull Request conversation thread. #223

IstoraMandiri opened this issue Oct 4, 2022 · 2 comments · May be fixed by #224
Labels
feature New feature or request

Comments

@IstoraMandiri
Copy link
Contributor

Pull request previews are a great feature, but currently it's not obvious where the previews are generated, especially for new users, as you have to navigate to "details" of the action to see the output.

It would be more intuitive if both the preview result and the publish results (tweet link) were added as a comment to the pull request conversation itself.
@IstoraMandiri IstoraMandiri added the feature New feature or request label Oct 4, 2022
@IstoraMandiri IstoraMandiri changed the title Include action result messages in Pull Request discussion thread. Include action result messages in Pull Request conversation thread. Oct 4, 2022
@IstoraMandiri IstoraMandiri mentioned this issue Oct 5, 2022
Closed
@gr2m
Copy link
Contributor

gr2m commented Oct 6, 2022

I agree that would be great.

were added as a comment to the pull request conversation itself.

it would be good if an existing comment would be updated instead of creating new comments. Alternatively the previous comment(s) could be hidden as "outdated"

@lemeurherve
Copy link

lemeurherve commented Oct 6, 2022 •
edited
Loading

it would be good if an existing comment would be updated instead of creating new comments

For inspiration/potential workaround with an additional GHA: https://github.com/peter-evans/create-or-update-comment

@IstoraMandiri IstoraMandiri linked a pull request Oct 14, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@gr2m @IstoraMandiri @lemeurherve