Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative media paths #214

Open
IstoraMandiri opened this issue Oct 2, 2022 · 3 comments
Open

Support relative media paths #214

IstoraMandiri opened this issue Oct 2, 2022 · 3 comments
Labels
feature New feature or request

Comments

@IstoraMandiri
Copy link
Contributor

IstoraMandiri commented Oct 2, 2022

What’s missing?

Currently media uploads need to be in a top level media directory.
To giver users optionality in how they organize their projects, they should be able to specify a relative file path for media uploads, allowing media to be organized alongside their relevant .tweet files with the tweets directory.

Why?

For projects with many tweets, especially with nested directories, a separate top level media folder may become disorganized, and specifying unique names for each file may be confusing.

@IstoraMandiri IstoraMandiri added the feature New feature or request label Oct 2, 2022
@IstoraMandiri IstoraMandiri changed the title Relative media paths Support relative media paths Oct 2, 2022
@MattIPv4
Copy link
Member

MattIPv4 commented Oct 2, 2022

There is nothing stopping folks from putting subdirectories within the media folder, unless there's a bug there I've missed? The only requirement is that the media folder is at the same level as the tweets folder, which seems a fair requirement to have given we require the tweets folder exactly the same.

@IstoraMandiri
Copy link
Contributor Author

IstoraMandiri commented Oct 2, 2022

I understand that the media folder can also be nested, but why force users to keep media and tweets in separate places?

Allowing associated files to exist next to each other in the same folder helps keep the directory structure DRY, organization is easier and less confusing for contributors, especially for larger projects.

tweets
   cats
      charlie
        cute.jpg
        catnip.tweet        
        kittens.jpg
        january-fun.tweet
  dogs
     spot
        fetch.tweet
        dinner.jpg
        dinner.tweet

Instead of

media
   cats
      charlie
        cute.jpg
        kittens.jpg
  dogs
     spot
        dinner.jpg
tweets
   cats
      charlie
        catnip.tweet        
        january-fun.tweet
  dogs
     spot
        fetch.tweet
        dinner.tweet

@MattIPv4
Copy link
Member

MattIPv4 commented Oct 2, 2022

Ah yeah true, I could see it being a bit of a pain to have a dedicated media directory if someone were using this action in a repo that were doing things other than just tweets etc.

I wonder if the best approach might be to accept a path as it is currently (e.g. cat.jpg) and then search in a few different places for it (/media, /tweets/media, /tweets).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants