remove requests dependency #401
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/multipart/blob/v0.2.5/multipart.py to comply with our linting
… to get a correct type error
twm
reviewed
Sep 21, 2024
| @@ -14,6 +28,7 @@ def head(url, **kwargs): | |||
| return _client(kwargs).head(url, _stacklevel=4, **kwargs) | |||
|
|
|||
|
|
|||
| @_like(HTTPClient.get) | |||
There was a problem hiding this comment.
Interesting approach... I have a branch somewhere where I started factoring out TypedDict for all the arguments but it is so painful I haven't worked up the will to finish it.
There was a problem hiding this comment.
Oh, huh, will Mypy actually do the right thing with a TypedDict in this context?
There was a problem hiding this comment.
(I do think I prefer this approach regardless, that one had just never occurred to me.)
There was a problem hiding this comment.
I expect it will given Unpack (my experience actually doing this is with Pyright).
I certainly agree that this is less painful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325
In order to know whether we are even testing the various requests extensions, we want to have type hints that actually reflect the signatures on all the helpers.
I've definitely bitten off more than I can chew for getting this done today, so if anyone else wants to have a look at this, please be my guest.