-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not working for archived chats #5
Comments
Hi @kana800 I was a little afraid of using these HTML attributes for a reason. That's why changed the previous implementation. Lines 5 to 17 in 94ab183
For example (an old project): An implementation like this has to be updated if the HTML tree, elements or attributes are changed by the owner. So, I have been wanting to look for common patterns instead of using HTML tree struct or exploring different HTML attributes; that might be bound to change. Let me know your thoughts about this? |
That is totally understandable; It would be pain if you have to update every time the web app gets updated.
web dev in general isn't my strong suit so I don't have any idea on how to approach something like this. I looked at some other implementation. |
No problem at all!
Damn, that is interesting. I believe this (hardcoded) implementation is always scary. |
blur not working for archived chats
Credits: Hritik Sharma
The text was updated successfully, but these errors were encountered: