Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eval): parse_number() #215

Merged
merged 4 commits into from
Aug 9, 2024
Merged

fix(eval): parse_number() #215

merged 4 commits into from
Aug 9, 2024

Conversation

santiagocardo
Copy link
Contributor

Fix Expression.Eval.parse_number/1 when handling strings combined with numbers and punctuations.

@fedme
Copy link
Contributor

fedme commented Aug 9, 2024

Thanks @santiagocardo! I have pushed a small change to try to parse the number as Integer first.

fedme
fedme approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@fedme fedme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @santiagocardo!

fedme
fedme reviewed Aug 9, 2024
View reviewed changes
test/expression/eval_test.exs Outdated Show resolved Hide resolved
@fedme fedme merged commit c84d220 into develop Aug 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedme fedme fedme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santiagocardo @fedme