Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe lack interface to add action policy and entity metadata #34

Open
songbinliu opened this issue Oct 3, 2017 · 1 comment
Open

Comments

@songbinliu
Copy link
Contributor

songbinliu commented Oct 3, 2017

Current implementation of turbo.probe does not provide the interface to add action policy for entities.

Without this interface, two issues may occur:
(1) The default values of the action policy may change over time, which may break kubeturbo;
(2) Won't be able to change the settings of the entities. For example, containerPod should be able to be Cloneable, but the default settings for containerPod may be not.

@songbinliu
Copy link
Contributor Author

songbinliu commented Dec 13, 2017

Introduction of action policy
Probes must specify action policies to indicate which actions are supported by the probe based on entity and action type. This information is used first after the market has recommended an action, whether the action is supported by a probe for recommendation or for action execution. If an action is accepted either by the user or automatically, the probe action policy is then used to determine which target will process the action based on the targets associated with the action and the probe action policies for the targets.

Action Policy Probe Specification
There are 3 action capabilities which can be specified for a given entity type + action type

  • SUPPORTED - means that the probe can execute this action
  • NOT_EXECUTABLE - means that the action can be recommended but cannot be executed by the probe
  • NOT_SUPPORTED - means that the action does not make any sense and should not be recommended related to this probe (disabled)

Probes should specify an action policy that includes all of the entity + action type that the probe supports

Probe should also specify any actions which should be disabled - NOT_SUPPORTED. This is used only to prevent an action from being displayed to the user

If the probe does not specify anything for a given entity type + action type it is by default - NOT_EXECUTABLE which means it would be displayed to the user in recommend mode

If an SDK probe does not specify an action policy as of 6.0, the default will be that all actions are not executable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant