Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple healthchecks for Tsuru app #2574

Open
nettoclaudio opened this issue Oct 7, 2022 · 4 comments
Open

Support multiple healthchecks for Tsuru app #2574

nettoclaudio opened this issue Oct 7, 2022 · 4 comments

Comments

@nettoclaudio
Copy link
Member

Is your feature request related to a problem? Please describe.
Tsuru only supports a single healthcheck configuration for the whole app. For apps with multiple processes only the "web" process can configure healthcheck - as you can see on k8s and docker provisioners.

Describe the solution you'd like
In order to avoid breaking changes in the Tsuru config file for apps (aka tsuru.yaml), the safest approach would be to create a new array property to hold the multiple health check configs. Each array item must provide the probe configs along the process name (which is required).

healthchecks:
- process: web
  path: /healthz
...
- process: worker
  command: ["/path/to/my/script.sh", "--healthcheck"]

But I also like the idea of supporting both solutions in the existing healthcheck property. So according to the type of healthcheck property, Tsuru does a thing or something else. When an array is presented, multiple probe configs are supported, otherwise, the legacy behavior is kept.

Describe alternatives you've considered
N/A

Additional context
N/A

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This issue is 53 days old, marking as stale! cc: @nettoclaudio

@github-actions
Copy link

github-actions bot commented May 5, 2023

This issue is 59 days old, marking as stale! cc: @nettoclaudio

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Issue last updated 61 days ago! Closing down!

@github-actions github-actions bot closed this as completed Jul 5, 2023
@wpjunior wpjunior reopened this Aug 9, 2024
Copy link

github-actions bot commented Nov 5, 2024

Issue last updated 87 days ago! Closing down!

@github-actions github-actions bot closed this as completed Nov 5, 2024
@wpjunior wpjunior reopened this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants