Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openTelemetry as optional #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

openTelemetry as optional #211

wants to merge 2 commits into from

Conversation

ngoctd314
Copy link

i have a basic solution for this issue
#210

dethi
dethi reviewed Feb 21, 2023
View reviewed changes
internal/observability/noop_span.go
}

var (
isNoopTracing = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think using a global variable here is the right approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dethi dethi dethi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngoctd314 @dethi