New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: error handling for missing footprint #253

Open

DhairyaMajmudar wants to merge 1 commit into tscircuit:main from DhairyaMajmudar:error

+11 −1

Open

lib/components/base-components/NormalComponent.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -62,6 +62,14 @@ @@
      *   }
      * }
      */
+    class MissingFootprintError extends Error {
+      constructor(message: string) {
+        super(message)
+        this.name = "MissingFootprintError"
+      }
+    }
     export class NormalComponent<
       ZodProps extends ZodType = any,
       PortNames extends string = never,
@@ Expand Down Expand Up / @@ -212,7 +220,9 @@ @@
       _addChildrenFromStringFootprint() {
         let { footprint } = this.props
         footprint ??= this._getImpliedFootprintString?.()
-        if (!footprint) return
+        if (!footprint) {
+          throw new MissingFootprintError("Footprint is missing")
+        }
         if (typeof footprint === "string") {
           const fpSoup = fp.string(footprint).soup()
           const fpComponents = createComponentsFromSoup(fpSoup as any) // Remove as any when footprinter gets updated
@@ Expand Down @@

Provide feedback