Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an option is enabled shouldDrawErrors draw trace_errors #52

Open
seveibar opened this issue Sep 9, 2024 · 4 comments
Open

If an option is enabled shouldDrawErrors draw trace_errors #52

seveibar opened this issue Sep 9, 2024 · 4 comments

Comments

@seveibar
Copy link
Contributor

seveibar commented Sep 9, 2024

tscircuit/soup zod export for trace_error

import { point } from "src/common"
import { z } from "zod"

export const pcb_trace_error = z
  .object({
    pcb_error_id: z.string(),
    type: z.literal("pcb_error"),
    error_type: z.literal("pcb_trace_error"),
    message: z.string(),
    center: point.optional(),
    pcb_trace_id: z.string(),
    source_trace_id: z.string(),
    pcb_component_ids: z.array(z.string()),
    pcb_port_ids: z.array(z.string()),
  })
  .describe("Defines a trace error on the PCB")

export type PCBTraceErrorInput = z.input<typeof pcb_trace_error>
export type PCBTraceError = z.infer<typeof pcb_trace_error>
@seveibar
Copy link
Contributor Author

seveibar commented Sep 9, 2024

Needed to fix this issue easily in tests: tscircuit/tscircuit#330 (comment)

Copy link

homie-gg bot commented Sep 9, 2024

This might be a duplicate of: Option to render trace_error (e.g. option showErrors: true).

Copy link

homie-gg bot commented Sep 9, 2024

Copy link

homie-gg bot commented Sep 24, 2024

This might have already been done via: updated to circuit-json and added pcb_trace_id to via.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant