Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arb nova chain #3365

Merged
merged 6 commits into from
Aug 16, 2023
Merged

add arb nova chain #3365

merged 6 commits into from
Aug 16, 2023

Conversation

XFantasy88
Copy link
Contributor

@XFantasy88 XFantasy88 commented Aug 14, 2023 •
edited
Loading

Description

Add support for Arbitrum Nova chain. For more information, visit visit the official site

How to test

Test in same manner as other EVM chains.

Types of changes

New feature (Arbitrum Nova support)

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

satoshiotomakan
satoshiotomakan previously approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lamafab
lamafab previously approved these changes Aug 14, 2023
View reviewed changes
@Milerius
Copy link
Collaborator

ios test failed @XFantasy88

@XFantasy88
Copy link
Contributor Author

XFantasy88 commented Aug 15, 2023 •
edited
Loading

Hi, @Milerius
Could you help me with Kotlin Multiplatform CI check please?
I am not sure what the issue is..

@satoshiotomakan
Copy link
Collaborator

@XFantasy88 this is a known issue.
You should change WC version here to 3.2.12 (the latest release)

wallet-core/samples/kmp/shared/build.gradle.kts

Line 38 in 85bb022

implementation("com.trustwallet:wallet-core-kotlin:3.2.11")

@XFantasy88
Copy link
Contributor Author

@XFantasy88 this is a known issue. You should change WC version here to 3.2.12 (the latest release)

wallet-core/samples/kmp/shared/build.gradle.kts

Line 38 in 85bb022

implementation("com.trustwallet:wallet-core-kotlin:3.2.11")

thanks for your kind help.

satoshiotomakan
satoshiotomakan requested changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo :)

include/TrustWalletCore/TWCoinType.h Outdated Show resolved Hide resolved
@Milerius Milerius merged commit 92b701f into trustwallet:master Aug 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milerius Milerius Milerius approved these changes

@lamafab lamafab lamafab approved these changes

@satoshiotomakan satoshiotomakan satoshiotomakan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XFantasy88 @Milerius @satoshiotomakan @lamafab