Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anime (ERC20) #28324

Merged
merged 10 commits into from
Jun 3, 2024
Merged

Add Anime (ERC20) #28324

merged 10 commits into from
Jun 3, 2024

Conversation

animeonbase
Copy link
Contributor

Adding info for ERC20 token 'Anime'.

PR created by TW Assets Management

@animeonbase
Copy link
Contributor Author

@Cryptocool1 Our previous pull request (#28101) had completed all requirements and payment, but was just waiting for CMC listing.

Our CMC listing is now available:
https://coinmarketcap.com/currencies/anime/

Thank you!

@animeonbase animeonbase mentioned this pull request May 29, 2024
@Cryptocool1 Cryptocool1 added the Payment Status: Paid Fee completely paid for PR label May 29, 2024
@Cryptocool1
Copy link
Collaborator

PAID #28101

@tw-daniel tw-daniel removed the Payment Status: Paid Fee completely paid for PR label May 30, 2024
@tw-daniel
Copy link
Contributor

/check

@merge-fee-bot
Copy link

merge-fee-bot bot commented May 30, 2024

Fee has not been received yet (or not fully).

@tw-daniel tw-daniel added the Payment Status: Paid Fee completely paid for PR label May 30, 2024
@animeonbase
Copy link
Contributor Author

Hi, is there anything else we need to do from our side to complete?

@Cryptocool1 @tw-daniel

@cryptomanz1 cryptomanz1 reopened this May 30, 2024
@merge-fee-bot
Copy link

merge-fee-bot bot commented May 30, 2024

PR Summary

Files OK: 2
Token in PR: ERC20 0x0e0c9756a3290cD782CF4aB73ac24D25291c9564
Symbol: ANIME decimals: 18
Links: Logo Info Website ExplorerFromInfo ExplorerFromID
Tags:
Token check error:
❌ explorer field incorrect: should be standard https://etherscan.io/token/0x0e0c9756a3290cD782CF4aB73ac24D25291c9564, not https://basescan.org/token/0x0e0c9756a3290cD782CF4aB73ac24D25291c9564
❌ invalid value 'https://x.com/animeonbase' for twitter link url, allowed only with prefix: https://twitter.com/
❌ at least 1 tag is required
❌ number of holders not checked: please, check it manually

@merge-fee-bot
Copy link

merge-fee-bot bot commented May 30, 2024

Hi! In order to compensate for the efforts of processing PRs, we kindly ask for a contribution.
💀 As there is no refund, before paying the fee, make sure new tokens fulfill the minimum circulation and other acceptance criteria.
See also the PR Fee FAQ.

Please pay 500 TWT with the memo 28324 to the TWT-BEP2 (Binance Chain) address bnb158fgd782we4tz9vwwcj9pmmxvxhl6z46lfm7c8.
Alternatively, 2 BNB is also accepted (same memo & address).

QR code: Trust | other wallet

TWT Acquiring:

Notes:

  • New tokens without significant usage are rejected, see criteria mentioned above.
  • One PR should be for a single project; PR's with more than 10 logos will be rejected.
  • Payment evaluation happens automatically, but with a few minutes delay. When payment is detected, an Accept Review is automatically placed on the PR, which is a condition for merge.
  • Evaluating the PR is done manually, and it is merged only if all conditions are satisfied.
    There will be a fee to process this request. None of it goes to the developers.
    Before paying the fee, make sure new tokens fulfill the minimum circulation and other acceptance criteria.
    If you are paying TWT for the submission, this will be burned automatically. There will be no refunds.

@animeonbase
Copy link
Contributor Author

@cryptomanz1 Fee was paid here #28101

We are failing the twitter link check because we are using the new X URL instead of twitter.com. We are also failing the explorer link check bc it is expecting etherscan but we are a base token so we use basescan.

@merge-fee-bot
Copy link

merge-fee-bot bot commented May 30, 2024

PR Summary

Files OK: 2
Token in PR: ERC20 0x0e0c9756a3290cD782CF4aB73ac24D25291c9564
Symbol: ANIME decimals: 18
Links: Logo Info Website ExplorerFromInfo ExplorerFromID
Tags:
Token check error:
❌ explorer field incorrect: should be standard https://etherscan.io/token/0x0e0c9756a3290cD782CF4aB73ac24D25291c9564, not https://basescan.org/token/0x0e0c9756a3290cD782CF4aB73ac24D25291c9564
❌ invalid value 'https://x.com/animeonbase' for twitter link url, allowed only with prefix: https://twitter.com/
❌ at least 1 tag is required
❌ number of holders not checked: please, check it manually

@animeonbase
Copy link
Contributor Author

Any guidance/feedback? Would love to get this approved.

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jun 2, 2024

PR Summary

Files OK: 2
Token in PR: ERC20 0x0e0c9756a3290cD782CF4aB73ac24D25291c9564
Symbol: ANIME decimals: 18
Links: Logo Info Website ExplorerFromInfo ExplorerFromID
Tags:
Token check error:
❌ explorer field incorrect: should be standard https://etherscan.io/token/0x0e0c9756a3290cD782CF4aB73ac24D25291c9564, not https://basescan.org/token/0x0e0c9756a3290cD782CF4aB73ac24D25291c9564
❌ invalid value 'https://x.com/animeonbase' for twitter link url, allowed only with prefix: https://twitter.com/
❌ at least 1 tag is required
❌ number of holders not checked: please, check it manually

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jun 2, 2024

PR Summary

Files OK: 2
Token in PR: ERC20 0x0e0c9756a3290cD782CF4aB73ac24D25291c9564
Symbol: ANIME decimals: 18
Links: Logo Info Website ExplorerFromInfo ExplorerFromID
Tags:
Token check error:
❌ explorer field incorrect: should be standard https://etherscan.io/token/0x0e0c9756a3290cD782CF4aB73ac24D25291c9564, not https://basescan.org/token/0x0e0c9756a3290cD782CF4aB73ac24D25291c9564
❌ invalid value 'https://x.com/animeonbase' for twitter link url, allowed only with prefix: https://twitter.com/
❌ at least 1 tag is required
❌ number of holders not checked: please, check it manually

@animeonbase
Copy link
Contributor Author

Thank you for the fix! Any update on when it will pushed live?

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jun 3, 2024

No token files found. If you try to add/modify a token, check the name and location of your files! Logo file must be named exactly 'logo.png'. If you are not adding a token, ignore this message.

@animeonbase
Copy link
Contributor Author

@cryptomanz1 @Cryptocool1 just wanted to confirm, that "type": "ERC20" is the correct input for a base token in our info.json. We are a base token but on the TW asset manager page you could not specify "base". I noticed other base tokens had "type": "BASE". Is "ERC20" value okay since base are erc20 tokens?

@merge-fee-bot
Copy link

merge-fee-bot bot commented Jun 3, 2024

No token files found. If you try to add/modify a token, check the name and location of your files! Logo file must be named exactly 'logo.png'. If you are not adding a token, ignore this message.

@cryptomanz1 cryptomanz1 merged commit 6687447 into trustwallet:master Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Payment Status: Paid Fee completely paid for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants