Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add beat version info #32

Open
SuperQ opened this issue Jan 14, 2020 · 6 comments
Open

Feature: add beat version info #32

SuperQ opened this issue Jan 14, 2020 · 6 comments
Labels
good first issue Good for newcomers

Comments

@SuperQ
Copy link
Contributor

SuperQ commented Jan 14, 2020

Feature idea, add beat info metrics from the stats endpoint /

{
  "beat": "pubsubbeat",
  "hostname": "pubsub-sidekiq-inf-gstg",
  "name": "pubsub-sidekiq-inf-gstg",
  "uuid": "FOO",
  "version": "7.5.1"
}

Would make a metrics like this:

pubsubbeat_build_info{version="7.5.1"} 1
pubsubbeat_beat_info{beat_name="pubsub-sidekiq-inf-gstg",uuid="FOO",} 1
@shivas
Copy link
Contributor

shivas commented Jan 14, 2020

beat version available in beat_exporter_target_info{beat="auditbeat",uri="localhost:",version="7.5.1"} adding UUID is tricky, as it's random value and could cause cardinality explosion? not sure how under the good UUID is generated

@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 14, 2020

Oh, strange, I checked for info metrics previously and didn't see it.

It seems like the UUID is stored in a meta.json written out by the beat. Should be stable enough to expose.

@shivas
Copy link
Contributor

shivas commented Jan 14, 2020

I understand name and hostname, but does UUID really have value to be exposed?

@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 14, 2020

Yes, there really is a UUID, at least on my instances. Having the UUID isn't that important to me, it was just an idea.

Weird, it seems like beat_exporter_target_info is not read at every scrape. I did some upgrade testing today and I saw no change in the version.

@shivas
Copy link
Contributor

shivas commented Jan 14, 2020

That data read only once on beat-exporter startup, so if you changed *beat without restarting actual exporter - could be u see stale data.

@shivas shivas added the good first issue Good for newcomers label Jan 14, 2020
@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 14, 2020

Ok, I will see about fixing the exporter to update at every scrape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants