Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support OpenID4VP - Mocked public store for request object #832

Conversation

mishasizov-SK
Copy link
Contributor

Linked ticket: #754

Signed-off-by: Mykhailo Sizov [email protected]

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 86.62% // Head: 86.59% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (bbde8a8) compared to base (083034d).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   86.62%   86.59%   -0.04%     
==========================================
  Files          55       56       +1     
  Lines        2565     2573       +8     
==========================================
+ Hits         2222     2228       +6     
- Misses        205      206       +1     
- Partials      138      139       +1     
Impacted Files Coverage Δ
component/oidc/vp/requestobjectstore.go 83.33% <83.33%> (ø)
cmd/vc-rest/startcmd/start.go 82.44% <0.00%> (-0.27%) ⬇️
cmd/vc-rest/startcmd/params.go 85.31% <0.00%> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mishasizov-SK mishasizov-SK force-pushed the feat_mocked_public_store_for_request_object branch from f4ea81f to a1ddbcc Compare October 3, 2022 14:13
@mishasizov-SK mishasizov-SK force-pushed the feat_mocked_public_store_for_request_object branch from a1ddbcc to bbde8a8 Compare October 3, 2022 15:04
@vkubiv vkubiv merged commit 7263512 into trustbloc:main Oct 3, 2022
@mishasizov-SK mishasizov-SK deleted the feat_mocked_public_store_for_request_object branch October 5, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants