Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple configuration files #36

Closed
dokempf opened this issue Aug 7, 2023 · 2 comments · Fixed by #44
Closed

Multiple configuration files #36

dokempf opened this issue Aug 7, 2023 · 2 comments · Fixed by #44
Labels
enhancement New feature or request
Milestone

Comments

@dokempf
Copy link

dokempf commented Aug 7, 2023

Thanks for this extension! I have written a Python package which ships with an entrypoint to install the jupyter_app_launcher config into the respective Jupyter data directories. For conda-forge packaging, this will happen already during package build, so that installing my conda package will directly show me the icons in the launcher. I really like this approach for my use case, but I have one problem with it: If for some reason, some other package would do the exact same trick, one would overwrite the other's config.

A solution to this would be to not fix the name of the configuration file to config.yml, but only fix its location to PREFIX/jupyter_app_launcher. The code discovering the config file would then need to glob the path for potential configuration files and use all of them. What do you think?

@trungleduc trungleduc added the enhancement New feature or request label Aug 7, 2023
@trungleduc
Copy link
Owner

Thanks for your suggestion, indeed this a great idea!. I will implement it in the next version, which is blocked by jupyterhub/jupyter-server-proxy#419

@trungleduc
Copy link
Owner

0.2.0 is released with this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants