Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulling short lived AWS keys into their own thing, fixes #1224 #2088

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

dylanTruffle
Copy link
Contributor

@dylanTruffle dylanTruffle commented Nov 2, 2023

Description:

Splits out short lived AWS tokens into its own detector.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@dylanTruffle dylanTruffle requested review from a team as code owners November 2, 2023 22:29
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ dylanTruffle
✅ zricethezav
❌ Chair


Chair seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dylanTruffle
Copy link
Contributor Author

these keys are short lived by nature, but you can generate them with:

aws sts get-session-token --duration-seconds 36000

@zricethezav zricethezav merged commit 0b90265 into main Nov 3, 2023
7 of 9 checks passed
@zricethezav zricethezav deleted the fix-aws-session branch November 3, 2023 16:58
@zricethezav zricethezav mentioned this pull request Nov 3, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants