Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move commits_scanned to ScanRepo #1610

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Move commits_scanned to ScanRepo #1610

merged 1 commit into from
Aug 7, 2023

Conversation

bill-rich
Copy link
Collaborator

Move commits_scanned from Chunks to ScanRepo to show up when the Git source is utilized from another source, such as GitHub.

@bill-rich bill-rich requested a review from a team as a code owner August 7, 2023 21:21
Copy link
Collaborator

@trufflesteeeve trufflesteeeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we'll get a "commits_scanned" per repo now, yeah? I think that makes sense.

@bill-rich bill-rich merged commit 2d2595a into main Aug 7, 2023
8 checks passed
@bill-rich bill-rich deleted the move_commits_scanned branch August 7, 2023 21:28
@ahrav
Copy link
Collaborator

ahrav commented Aug 7, 2023

So we'll get a "commits_scanned" per repo now, yeah? I think that makes sense.

I don't think that's quite accurate. We init Git only once for a Github source for example. This means if we are scanning 100 repos the commit count will be for all 100 repos. We would just be logging whenever a repo is done scanning. I don't think that value would be for only the repo that completed, but all commits for all the repos up to that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants