Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] - Remove password info from log #1528

Merged
merged 3 commits into from
Jul 23, 2023
Merged

[chore] - Remove password info from log #1528

merged 3 commits into from
Jul 23, 2023

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Jul 23, 2023

  • If the clone fails we log the remotePath which contains credentials.

@ahrav ahrav marked this pull request as ready for review July 23, 2023 00:45
@ahrav ahrav requested a review from a team as a code owner July 23, 2023 00:45
mcastorina
mcastorina approved these changes Jul 23, 2023
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the only place we could log it?

@ahrav
Copy link
Collaborator Author

ahrav commented Jul 23, 2023

Is that the only place we could log it?

Just found one more. I think that should be all, but I didn't do a really deep dive. These just popped up while I was working on an on-call issue. I'll create a ticket as a follow up to do a second pass.

@ahrav ahrav merged commit 9e0a2e9 into main Jul 23, 2023
8 checks passed
@ahrav ahrav deleted the chore-redact-sensitive-info branch July 23, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @mcastorina