Improve dev tooling #51
Conversation
| @@ -3,6 +3,7 @@ module.exports = { | |||
| env: { | |||
| browser: true, | |||
| es2021: true, | |||
| node: true, | |||
There was a problem hiding this comment.
Fixes lint errors within the config files — could otherwise ignore them but this is just as easy
There was a problem hiding this comment.
Instead of doing this for the entire project, add this comment at the top of the config files:
/* eslint-env node */
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| pnpm exec commitlint --edit |
There was a problem hiding this comment.
So instead of commitizen prompting us for a commit message and all that, this just ensures that we follow Conventional Commits (which Semantic Release requires). Wastes a little less time.
There was a problem hiding this comment.
nit: move this to npx? We moved away from pnpm
| @@ -1,4 +1,4 @@ | |||
| #!/bin/sh | |||
| . "$(dirname "$0")/_/husky.sh" | |||
|
|
|||
| npm run format && npm run test | |||
| npx lint-staged | |||
There was a problem hiding this comment.
Adds formatted files to the commit, just a quality of life thing idk why I set this up without it 🤔
| "@semantic-release/github", | ||
| "@semantic-release/git", |
There was a problem hiding this comment.
These plugins should update the package.json version after publishing 👍
estrattonbailey
requested review from
christianbundy,
manan30 and
wjohnson-truework
No description provided.