Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate warm moist bubble test case #24

Open
benegee opened this issue Jul 24, 2024 · 2 comments
Open

Investigate warm moist bubble test case #24

benegee opened this issue Jul 24, 2024 · 2 comments

Comments

@benegee
Copy link
Collaborator

benegee commented Jul 24, 2024

This test case features a strange hump on top of the bubble and should be worth looking at
image

The most complicated part actually is the computation of the hydrostatic initial condition.

We can do it as in #2, cf.

function moist_state(y, dz, y0, r_t0, theta_e0,

or, alternatively, as done here:
https://github.com/trixi-framework/Trixi.jl/blob/cadf32b2f617acc239a53542ba0e5597e7c5cc0b/examples/structured_2d_dgsem/elixir_eulermultimoist_warm_bubble.jl#L19

The latter was adopted from a Fortran code by one of the authors of the paper. It does not require NLSolve, but in the end I did not notice a significant difference.

@tristanmontoya
Copy link
Member

I think this (or at least a very similar case to the one pictured) is now addressed with #2.

@benegee
Copy link
Collaborator Author

benegee commented Aug 20, 2024

True!

Maybe we can leave this open to track further developments? I think we will see this test case quite often in the near future.

@benegee benegee changed the title Get warm moist bubble test case running Investigate warm moist bubble test case Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants