Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging thesis_gemein_2022 into TrixiAtmo.jl #1

Closed
Arpit-Babbar opened this issue Jul 7, 2024 · 2 comments
Closed

Merging thesis_gemein_2022 into TrixiAtmo.jl #1

Arpit-Babbar opened this issue Jul 7, 2024 · 2 comments

Comments

@Arpit-Babbar
Copy link
Member

Arpit-Babbar commented Jul 7, 2024

In the branch https://github.com/trixi-framework/TrixiAtmo.jl/tree/ab_lucas, I am trying to add the results from https://github.com/NichtLucas/Trixi.jl/tree/thesis_gemein_2022 using Trixi as a dependency.

Here is the $v_2$ velocity plot from the elixir https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/examples/elixir_moist_euler_nonhydrostatic_gravity_waves.jl

image

I have not made any changes to the internals of the code from https://github.com/trixi-framework/TrixiAtmo.jl/blob/ab_lucas/examples/elixir_moist_euler_nonhydrostatic_gravity_waves.jl, just added import and using as needed. We could do some more tests for validation. If things are okay, we can decide how to merge this into main (how to break into PRs and review).

@sloede
Copy link
Member

sloede commented Jul 7, 2024

Nice work! Can you please create a draft PR such that we can see how much code would have to be merged, in order to make an informed decision?

@tristanmontoya
Copy link
Member

Completed in #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants