Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcell limiting: Improving interface for get_boundary_outer_state() #2053

Open
bennibolm opened this issue Aug 29, 2024 · 0 comments
Open

Comments

@bennibolm
Copy link
Contributor

bennibolm commented Aug 29, 2024

The subcell limiting on non-periodic domains requires boundary solution states to calculate subcell limiting bounds. For that, we implemented get_boundary_outer_state.

get_boundary_outer_state(u_inner, t,
                         boundary_condition,
                         normal_direction,
                         (direction,) # only for TreeMesh and StructuredMesh
                         mesh, equations,
                         dg, cache, indices...)

It requires some boundary information within the volume integral. That and its interface itself is somehow ugly and really messy.
#1954 added multiple new versions. After a discussion, we decided to add new versions to the elixir itself.

When there are more versions and/or we found a better way to fit this properly into Trixi, those functions can be saved in a more general file.

Right now, there are 4 versions of it in main:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant