Print summary_callback as finalizer

[ranocha]

Since SciML/OrdinaryDiffEq.jl#2061 (comment) just got merged, we could consider printing the output of the summary_callback automatically after finishing solve without having to call it manually. However, I would consider this to be breaking since it will just be annoying to print it twice if it's already called manually.

[JoshuaLampert]

I like printing the summary_callback automatically after finishing solve. As a side note: I implemented something like this without a finalize function also here. But of course it would be nicer with a proper finalize function.

[ranocha]

Yeah,

https://github.com/JoshuaLampert/DispersiveShallowWater.jl/blob/492f918f040f3103f9b062d21538d36e9a2c877a/src/callbacks_step/summary.jl#L16-L17

is already nice. However, our default setup is to have the summary callback as first callback. Thus, if we activate it like this in the last step, the report will miss calls to the other callbacks in the final step (such as the final IO etc.). As far as I understand, finalize should be better since it should capture also the last call to other callbacks.

[JoshuaLampert]

Yes, that's true. That's also why I just opened a PR there to use finalize and it works nicely.

[JoshuaLampert]

If this is something we want to have in Trixi.jl, I am happy to prepare a PR that can be included in the next breaking release.

[ranocha]

Let's gather some opinions first. What do @trixi-framework/principal-developers think about this?

Pro

• No need to call summary_callback() at the end of a simulation manually

Con

• Requires a new version of OrdinaryDiffEq.jl that supports only Julia v1.9 and newer (not v1.8, the minimum required version we have so far)