Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction with nVersion=2 #15374

Open
peter-sanderson opened this issue Nov 13, 2024 · 0 comments
Open

Transaction with nVersion=2 #15374

peter-sanderson opened this issue Nov 13, 2024 · 0 comments
Assignees

Comments

@peter-sanderson
Copy link
Contributor

peter-sanderson commented Nov 13, 2024

@andrewkozlik:

The implication is that to make use of BIP68 you need nVersion to be 2. Indeed, it appears to be the only reason why someone would need to use nVersion 2, but that's actually beside the point IMO. We don't make use of the feature specified in BIP68, so we can use nVersion 1 or 2. So the only question is which nVersion makes Trezor Suite stand out the least. That would seem to be nVersion 2.


Produce transactions with nVersion=2 to reduce a fingerprint surface as it seems most of the wallets use the version 2. And it enables the BIP68

Sources:

@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Nov 13, 2024
@peter-sanderson peter-sanderson changed the title nVersion=2 Transaction with nVersion=2 Nov 13, 2024
@peter-sanderson peter-sanderson self-assigned this Nov 14, 2024
@sime sime moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏃‍♀️ In progress
Development

No branches or pull requests

1 participant