Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuild for arm64 for Linux and Windows #226

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

verhovsky
Copy link
Collaborator

Closes #225

@shivamsouravjha
Copy link

@ObserverOfTime please review this as

@ObserverOfTime
Copy link
Member

Bumping node-gyp-build to v4.8.2 may or may not fix this.
Might as well bump all the deps while you're at it and/or set up dependabot.

@ObserverOfTime
Copy link
Member

Try lowering the Python version to 3.11 with actions/setup-python.

If that doesn't work, disable Node 22 on Windows. ¯\_(ツ)_/¯

@shivamsouravjha
Copy link

shivamsouravjha commented Sep 16, 2024

Hey @verhovsky in the interest of time can we try to get the linux one merged before? as windows might be dependent on further dependencies

@verhovsky verhovsky force-pushed the arm64-prebuild branch 2 times, most recently from 7cf9dab to 586a098 Compare September 16, 2024 17:57
@verhovsky verhovsky merged commit c5a4976 into tree-sitter:master Sep 16, 2024
21 checks passed
@shivamsouravjha
Copy link

Any idea when we can see this in release? Very much keen in seeing this released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prebuild: doesn't have arm-64
3 participants