rough concept: detect pipe when calling job:show command #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This concept improve `td job:result` comand when playing query with small set of result. In most cases, Hive's `ORDER BY` takes 30 ~ 40 seconds as itself's initialization costs. so I'd like to sort the result on local machine. for examples: ```` td job:show 123456 | sort -k 1 -k 2 -n ```` Unfortunately, my ruby skill is really poor. so could you consider this concept at first? Thanks, Shuhei
ghost
assigned 
| @@ -26,6 +26,8 @@ module Command | |||
| /\A[\+]?2\z/ => 2, | |||
| } | |||
|
|
|||
| is_tty = true | |||
There was a problem hiding this comment.
@is_tty ?
or how define is_tty? method?
def on_tty?
STDOUT.tty?
endThere was a problem hiding this comment.
yea. probably to define method is good way for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concept improves
td job:resultcomand when playing query with small set of result.In most cases, Hive's
ORDER BYtakes 30 ~ 40 seconds as itself's initialization costs.so I'd like to sort the result on local machine. for examples:
Unfortunately, my ruby skill is really poor. so could you consider this concept at first?
Thanks,
Shuhei