Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lager is missing as a dependency #21

Closed
tverlaan opened this issue Apr 7, 2016 · 4 comments
Closed

lager is missing as a dependency #21

tverlaan opened this issue Apr 7, 2016 · 4 comments

Comments

@tverlaan
Copy link
Contributor

tverlaan commented Apr 7, 2016

Lager is missing as a dependency in rebar.config. I wanted to create a PR directly but I'm not sure how you would like to resolve this (since I also see a 'use_hut' branch). Are you okay with fetching lager from hex.pm? Or do you want to pull it from github?

I'm using mix which currently can't resolve the dependencies correctly which causes compilation to fail.

Ps. Are you interested in publishing this package on hex? I would gladly create a PR.

@surik
Copy link
Contributor

surik commented Apr 7, 2016

Which revision of exometer_core do you use?

@tverlaan
Copy link
Contributor Author

tverlaan commented Apr 7, 2016

Good question! I'm using a newer version apparently. Switching to the older version indeed solves the dep problem. Thanks!

Is there a reason not to support newer versions of exometer_core? AFAICT adding lager as a dependency is all it would need.

@surik
Copy link
Contributor

surik commented Apr 7, 2016

We don't use a newer version because it is not ready. See Feuerlabs/exometer_core#57

@tverlaan
Copy link
Contributor Author

tverlaan commented Apr 7, 2016

I see. Thanks again!
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants