Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing only some connectors from source fails #967

Open
sbidin opened this issue May 27, 2022 · 4 comments
Open

Installing only some connectors from source fails #967

sbidin opened this issue May 27, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@sbidin
Copy link

sbidin commented May 27, 2022

Describe the bug
Following the instructions for installing only some connectors (not all defaults) from source results in an error.

$ make pipelinewise connectors -e pw_connector=tap-postgres,target-snowflake
... <snip> ...
ERROR: Directory not exists and does not look like a valid singer connector: singer-connectors: singer-connectors/tap-postgrestarget-snowflake

To Reproduce

  1. run make pipelinewise connectors -e pw_connector=tap-postgres,target-snowflake
  2. see error

Expected behavior
The separate connectors each get installed.

Your environment

  • pipelinewise 0.45.0, commit 58b88e2

Additional context
Possibly the documentation is simply out of date? Attached screenshot. There is no --connectors argument (rather only the connectors subcommand). Specifying the connectors as separated by spaces (and quoted together) instead of by commas fixes the issue.
2022-05-27-140537_934x237_scrot

@sbidin sbidin added the bug Something isn't working label May 27, 2022
@Samira-El
Copy link
Contributor

Hey, it's working fine by me, our end to end tests CI job is also installing only a subset of connectors here and they're working fine.

Seeing the bit singer-connectors/tap-postgrestarget-snowflake in the error you shared makes me assume either your OS or Make on your machine is not recognizing the comma separator so ends up concatenating the connector names as one.

What OS you're running this command on and what Make version do you have?

@sbidin
Copy link
Author

sbidin commented May 27, 2022

Ah, then I suppose it's something about my setup. I'm using:

  • Arch Linux, updated
  • GNU Make 4.3
  • Python 3.9.12 (including this because setup fails for me on 3.10+ due to other reasons)

@Samira-El
Copy link
Contributor

Installation scripts are not tested on Arch linux.
I advise you to spin up Pipelinewise as a docker container, the official images are here

@gbatiz
Copy link

gbatiz commented Sep 30, 2022

Had the same issue. (Also Arch linux, although I cant't see how it can be relevant for the problem).
My workaround was to use separate commands:

make pipelinewise connectors -e pw_connector=tap-mysql -e pw_acceptlicenses=y
make pipelinewise connectors -e pw_connector=target-snowflake -e pw_acceptlicenses=y
make pipelinewise connectors -e pw_connector=transform-field -e pw_acceptlicenses=y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants