Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tower exhibits indirect memory leak probably due to usage of clone(). #668

Open
lkorenc opened this issue Jul 11, 2024 · 0 comments
Labels
bug Something isn't working mlir tower

Comments

@lkorenc
Copy link
Contributor

lkorenc commented Jul 11, 2024

VAST version

master

LLVM version

18

Operating system

CI

Description

It is unclear why this happens, but looks like clone() method leaves some indirect memory leak. According to the provided information it seems like some sort of cycle in the ptrs (as there is no direct leak) an the offenders seems to be ll::ReturnOp and Scope.

This is unrelated to tower per-se, because the leak can be reproduced by vast-front if a clone operation is inserted at the end of conversion passes.

It is not obvious where this bug originates from, candidates are (in no particular order):

  • We are using clone in a way we cannot
  • There is something wrong in the definitions of some of our operations that leads to an incomplete erase
  • There is a bug in upstream

Steps to Reproduce

Run the test/repl/raise.c with address sanitizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mlir tower
Projects
None yet
Development

No branches or pull requests

1 participant