Added Swift rule for nil assignment to implicilty unwrapped optional #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bismuthsalamander
requested review from
GrosQuildu and
mschwager
as code owners
|
|
mschwager
reviewed
Aug 15, 2024
Comment on lines
+23
to
+30
| - pattern-inside: | ||
| pattern-either: | ||
| - pattern: | | ||
| var $VAR: Int! = nil | ||
| (...) | ||
| - pattern: | | ||
| var $VAR: Int! | ||
| (...) |
There was a problem hiding this comment.
Huh, I'm kinda surprised this runs. AFAIK, pattern-inside must take a string, not a child YAML object. IMO a better way to structure this would be to have the pattern-either as the parent pattern, and have two pattern-insides underneath.
I think taint mode is another great option here. It perfectly matches what you're trying to achieve here. The patterns above would be the sources, the pattern-nots would be sanitizers, and the pattern below would be the sink.
There was a problem hiding this comment.
Thanks for the review. Given CodeQL's inability to richly express variable types, I'm going to chuck this for a CodeQL version at some point in the future. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Swift rule for assigning nil to an implicitly unwrapped optional (e.g.,
var num: Int! = 5; num = nil;). Updated the rule table generator to include Swift as another language. If we wanted, we could put Swift in a subdirectory called iOS with Objective-C rules in there as well (when we write some).