Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kraken rules #63

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Add Kraken rules #63

merged 8 commits into from
Jun 21, 2024

Conversation

bsamuels453
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2024

CLA assistant check
All committers have signed the CLA.

Vasco-jofra
Vasco-jofra previously approved these changes Jun 21, 2024
Copy link
Contributor

@Vasco-jofra Vasco-jofra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, The ...-negative file is not tested when using semgrep --test, but I see why you had to use it, I think it's ok.

The rules LGTM, I think we can merge

go/eth-rpc-tracetransaction.yaml Show resolved Hide resolved
go/eth-rpc-tracetransaction.yaml Show resolved Hide resolved
go/eth-rpc-tracetransaction.yaml Outdated Show resolved Hide resolved
go/eth-txreceipt-status.yaml Outdated Show resolved Hide resolved
@GrosQuildu GrosQuildu merged commit afaee64 into main Jun 21, 2024
3 checks passed
@GrosQuildu GrosQuildu deleted the kraken-rules branch June 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants