Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go lock fixes #59

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Go lock fixes #59

merged 4 commits into from
Apr 3, 2024

Conversation

GrosQuildu
Copy link
Collaborator

@GrosQuildu GrosQuildu commented Apr 3, 2024 •
edited
Loading

Vasco-jofra
Vasco-jofra approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Vasco-jofra Vasco-jofra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Vasco-jofra Vasco-jofra merged commit 772f68e into main Apr 3, 2024
3 checks passed
@Vasco-jofra Vasco-jofra deleted the go-lock-fixes branch April 3, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vasco-jofra Vasco-jofra Vasco-jofra approved these changes

@mschwager mschwager Awaiting requested review from mschwager mschwager is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing-runlock-on-rwmutex and missing-unlock-before-return do not specify lock variable in message
2 participants
@GrosQuildu @Vasco-jofra