Fix unbounded ellipsis match in tar-insecure-flags rule #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are edge cases wherein the unbounded ellipsis in the rule set will unintentionally wrap across multiple lines and match on a flag in a completely different command. This test case illustrates one such condition.
This prevents multiline span matching across different commands in some edge cases.
|
|
mschwager
reviewed
Feb 6, 2024
|
Working on a fix for CI here: #52 |
Co-authored-by: mschwager <[email protected]>
mschwager
approved these changes
Feb 8, 2024
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have run across false positive matches on the tar-insecure-flags rule in some edge cases. Semgrep Support recommended this as a fix.