Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better ci #40

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Better ci #40

merged 8 commits into from
Jan 2, 2024

Conversation

GrosQuildu
Copy link
Collaborator

  • use prettier linter
  • use r2c's script to validate rules' schemas
  • use semgrep yaml rules to validate rules

Vasco-jofra
Vasco-jofra previously approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@Vasco-jofra Vasco-jofra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one comment I added, LGTM

.github/workflows/semgrep-rules-test.yml Outdated Show resolved Hide resolved
@Vasco-jofra Vasco-jofra merged commit 04b8335 into main Jan 2, 2024
3 checks passed
@Vasco-jofra Vasco-jofra deleted the better-ci branch January 2, 2024 14:40
@GrosQuildu GrosQuildu mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vasco-jofra Vasco-jofra Vasco-jofra approved these changes

@suhacker1 suhacker1 Awaiting requested review from suhacker1 suhacker1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrosQuildu @Vasco-jofra