Reduce FPs for rule

trailofbits · Jul 12, 2023 · 915d140 · 915d140
1 parent 96893ac
commit 915d140
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/go/invalid-usage-of-modified-variable.go b/go/invalid-usage-of-modified-variable.go
@@ -1,6 +1,7 @@
 package main
 
 import (
+	"math/rand"
 	"fmt"
 )
 
@@ -263,6 +264,26 @@ func getEngineerAddressByIndex(slice []Engineer, idx int) (*Address, error) {
 	return slice[idx].Address, nil
 }
 
+func getRandEngineer(slice []Engineer) (*Engineer, error) {
+	idx := rand.Int()
+	// ok: invalid-usage-of-modified-variable
+	eng, err := getEngineerAtIndex(slice, idx)
+	if err != nil {
+		return eng, err
+	}
+	return eng, nil
+}
+
+func getRandAddress(slice []Engineer) (*Address, error) {
+	idx := rand.Int()
+	// ruleid: invalid-usage-of-modified-variable
+	eng, err := getEngineerAtIndex(slice, idx)
+	if err != nil {
+		return eng.Address, err
+	}
+	return eng.Address, nil
+}
+
 func getEngineers() []Engineer {
 	return []Engineer{
 		{

diff --git a/go/invalid-usage-of-modified-variable.yaml b/go/invalid-usage-of-modified-variable.yaml
@@ -37,4 +37,9 @@ rules:
         if err != nil {
           $X = ...
         }
+    - pattern-not: |
+        $X, err = ...
+        if err != nil {
+          return $X, err
+        }